Messages in this thread Patch in this message | | | From | Yihao Han <> | Subject | [PATCH] perf cs-etm: use swap() to make code cleaner | Date | Thu, 11 Nov 2021 18:33:44 -0800 |
| |
Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid opencoding it.
Signed-off-by: Yihao Han <hanyihao@vivo.com> --- tools/perf/util/cs-etm.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index f323adb1af85..aaa3ec725002 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -408,17 +408,13 @@ struct cs_etm_packet_queue static void cs_etm__packet_swap(struct cs_etm_auxtrace *etm, struct cs_etm_traceid_queue *tidq) { - struct cs_etm_packet *tmp; - if (etm->sample_branches || etm->synth_opts.last_branch || etm->sample_instructions) { /* * Swap PACKET with PREV_PACKET: PACKET becomes PREV_PACKET for * the next incoming packet. */ - tmp = tidq->packet; - tidq->packet = tidq->prev_packet; - tidq->prev_packet = tmp; + swap(tidq->packet, tidq->prev_packet); } } -- 2.17.1
| |