Messages in this thread | | | Date | Thu, 11 Nov 2021 22:33:40 +0100 | Subject | Re: [PATCH v3 3/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add RPM and fixed regulators | From | Konrad Dybcio <> |
| |
On 11.11.2021 04:16, Dang Huynh wrote: > Subject: > [PATCH v3 3/8] arm64: dts: qcom: sdm660-xiaomi-lavender: Add RPM and fixed regulators > From: > Dang Huynh <danct12@riseup.net> > Date: > 11.11.2021, 04:16 > > To: > Dang Huynh <danct12@riseup.net> > CC: > Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Herring <robh+dt@kernel.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Min <alexey.min@gmail.com>, Caleb Connolly <caleb@connolly.tech>, Martin Botka <martin.botka@somainline.org>, Konrad Dybcio <konradybcio@gmail.com> > > > Add most of the RPM PM660/PM660L regulators and the fixed ones, > defining the common electrical part of this platform. > > Reviewed-by: Caleb Connolly <caleb@connolly.tech> > Reviewed-by: Konrad Dybcio <konradybcio@gmail.com> As explained by Marijn in an email in this thread, please drop this line, as I did not approve the patch, and definitely not from that email :P
> + > + vreg_s1b_1p125: s1 { > + regulator-min-microvolt = <1125000>; > + regulator-max-microvolt = <1125000>; > + regulator-enable-ramp-delay = <200>; > + regulator-ramp-delay = <0>; I don't think setting a ramp delay of 0 does anything, this goes for every instance of this in the patch.
Konrad
| |