Messages in this thread | | | From | Andy Shevchenko <> | Date | Thu, 11 Nov 2021 22:39:34 +0200 | Subject | Re: [PATCH 04/17] media: atomisp: pci: do not use err var when checking port validity for ISP2400 |
| |
On Thu, Nov 11, 2021 at 9:41 PM Mauro Carvalho Chehab <mchehab@kernel.org> wrote: > Em Thu, 11 Nov 2021 18:09:49 +0200 > Andy Shevchenko <andriy.shevchenko@linux.intel.com> escreveu: > > On Thu, Nov 11, 2021 at 11:34:23PM +0900, Tsuchiya Yuto wrote:
...
> > I just realize that we may do at some point > > > > cflags-y += -Werror > > > > to avoid changes that breaks build (with warnings). > > No need. Upstream already added Werror. It is just a matter of > adding: > > CONFIG_WERROR=y > > to .config.
Unfortunately this is not gonna work with `make W=1`. https://lore.kernel.org/lkml/CAHp75Vef8QW3Y0yA702KUqPDHNRLN0kCv06=cgPpgPbUeAb-dw@mail.gmail.com/T/#u
> > And also I would suggest > > to run build with `make W=1 C=1 CF=-D__CHECK_ENDIAN__ ...` > > Yeah, that's good. On media, we also require no (unjustified) sparse > and smatch warnings.
-- With Best Regards, Andy Shevchenko
| |