| Date | Wed, 10 Nov 2021 23:55:21 -0800 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v2 00/23] x86: Remove anonymous out-of-line fixups |
| |
On Wed, Nov 10, 2021 at 11:01:02AM +0100, Peter Zijlstra wrote: > Changes since v1: > > - Dropped using __cold on labels, because clang. Also gcc doesn't actually > generate different code with it. The intent was for the code to end up in > .text.cold but that doesn't happen. > - Fixed the vmread constraints to disallow %0 == %1. > - Added a asm-goto-output variant to vmx's vmread implementation. > - Audited Xen and FPU code and converted them from -1 to -EFAULT, > as a concequence EX_TYPE_NEG_REG no longer exists. > - Fixed the EX_DATA_*_MASK macros to include an explicit 'int' cast, > such that FIELD_GET() will sign-extend the top field.
I didn't (yet) get the chance to properly review the alignment math in patches 20 & 21. Otherwise it looks great to me.
Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>
-- Josh
|