Messages in this thread | | | Date | Thu, 11 Nov 2021 19:37:42 +0000 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH 04/17] media: atomisp: pci: do not use err var when checking port validity for ISP2400 |
| |
Em Thu, 11 Nov 2021 18:09:49 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> escreveu:
> On Thu, Nov 11, 2021 at 11:34:23PM +0900, Tsuchiya Yuto wrote: > > On Mon, 2021-11-01 at 14:10 +0000, Mauro Carvalho Chehab wrote: > > > Em Mon, 01 Nov 2021 22:38:55 +0900 > > > Tsuchiya Yuto <kitakar@gmail.com> escreveu: > > ... > > > The full output of the make error is here: > > > > ("NOTE: issue: some undeclared errors") > > https://github.com/kitakar5525/linux-kernel/commit/a932d16681f941161385659b9d0316a3a4975e86 > > I just realize that we may do at some point > > cflags-y += -Werror > > to avoid changes that breaks build (with warnings).
No need. Upstream already added Werror. It is just a matter of adding:
CONFIG_WERROR=y
to .config.
> And also I would suggest > to run build with `make W=1 C=1 CF=-D__CHECK_ENDIAN__ ...`
Yeah, that's good. On media, we also require no (unjustified) sparse and smatch warnings.
Regards, Mauro
| |