lkml.org 
[lkml]   [2021]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] arm64: dts: qcom: Add support for SONY Xperia XZ2 / XZ2C / XZ3 (Tama platform)
From
Date
Il 11/11/21 03:16, Konrad Dybcio ha scritto:
>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
>> new file mode 100644
>> index 000000000000..6b088675f4b9
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi
>> @@ -0,0 +1,442 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +/*
>> + * Copyright (c) 2021, Konrad Dybcio <konrad.dybcio@somainline.org>
>> + */
>> +
>> +#include <dt-bindings/input/input.h>
>> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>> +#include "sdm845.dtsi"
>> +#include "pm8005.dtsi"
>> +#include "pm8998.dtsi"
>> +#include "pmi8998.dtsi"
>> +
>> +/ {
>> + qcom,msm-id = <321 0x20001>; /* SDM845 v2.1 */
>> + qcom,board-id = <8 0>;
>> +
>> + gpio-keys {
>
> Whooops! It seems that I totally forgot to add a compatible to gpio-keys.. Could that be fixed when applying if the patch is otherwise good? Should it not be the case, I'll surely fix that in the next revision..


Just send a v2 of it, please. Makes it easier on the maintainers.

Apart from that,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

\
 
 \ /
  Last update: 2021-11-11 18:56    [W:0.048 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site