lkml.org 
[lkml]   [2021]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] selftests: net: properly support IPv6 in GSO GRE test
On Thu, Nov 11, 2021 at 07:20:48AM -0800, Jakub Kicinski wrote:
> On Thu, 4 Nov 2021 11:46:13 +0100 Andrea Righi wrote:
> > Explicitly pass -6 to netcat when the test is using IPv6 to prevent
> > failures.
> >
> > Also make sure to pass "-N" to netcat to close the socket after EOF on
> > the client side, otherwise we would always hit the timeout and the test
> > would fail.
> >
> > Without this fix applied:
> >
> > TEST: GREv6/v4 - copy file w/ TSO [FAIL]
> > TEST: GREv6/v4 - copy file w/ GSO [FAIL]
> > TEST: GREv6/v6 - copy file w/ TSO [FAIL]
> > TEST: GREv6/v6 - copy file w/ GSO [FAIL]
> >
> > With this fix applied:
> >
> > TEST: GREv6/v4 - copy file w/ TSO [ OK ]
> > TEST: GREv6/v4 - copy file w/ GSO [ OK ]
> > TEST: GREv6/v6 - copy file w/ TSO [ OK ]
> > TEST: GREv6/v6 - copy file w/ GSO [ OK ]
> >
> > Fixes: 025efa0a82df ("selftests: add simple GSO GRE test")
> > Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
>
> This breaks the test for me on Fedora now :(

Oops, sorry about that.

>
> nc: invalid option -- 'N'
> Ncat: Try `--help' or man(1) ncat for more information, usage options and help. QUITTING.
> TEST: GREv6/v4 - copy file w/ TSO [FAIL]
> nc: invalid option -- 'N'
> Ncat: Try `--help' or man(1) ncat for more information, usage options and help. QUITTING.
> TEST: GREv6/v4 - copy file w/ GSO [FAIL]
> nc: invalid option -- 'N'
> Ncat: Try `--help' or man(1) ncat for more information, usage options and help. QUITTING.
> TEST: GREv6/v6 - copy file w/ TSO [FAIL]
> nc: invalid option -- 'N'
> Ncat: Try `--help' or man(1) ncat for more information, usage options and help. QUITTING.
> TEST: GREv6/v6 - copy file w/ GSO [FAIL]
>
> Tests passed: 0
> Tests failed: 4
>
>
> Can you please test this on your distro?

Tested, it works fine in Ubuntu as well:

$ sudo ./tools/testing/selftests/net/gre_gso.sh
TEST: GREv6/v4 - copy file w/ TSO [ OK ]
TEST: GREv6/v4 - copy file w/ GSO [ OK ]
TEST: GREv6/v6 - copy file w/ TSO [ OK ]
TEST: GREv6/v6 - copy file w/ GSO [ OK ]

Tests passed: 4
Tests failed: 0

Tested-by: Andrea Righi <andrea.righi@canonical.com>

\
 
 \ /
  Last update: 2021-11-11 16:32    [W:0.106 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site