Messages in this thread | | | Date | Thu, 11 Nov 2021 11:54:35 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v2 0/3] perf arm-spe: Add snapshot mode support |
| |
Em Thu, Nov 11, 2021 at 04:46:21PM +0800, Leo Yan escreveu: > Hi Arnaldo, > > On Tue, Nov 09, 2021 at 04:30:06PM +0000, German Gomez wrote: > > This patchset adds snapshot mode support for arm-spe. > > > > - [PATCH 1/3] implements the minimal callbacks to support recording in > > snapshot mode. > > - [PATCH 2/3] implements the find_snapshot callback in order to handle > > wrap-arounds in the AUX buffer. > > - [PATCH 3/3] adds a test for spe snapshot mode. > > I have verified this patch set on Hisilicon D06 board, please consider > to pick up: > > root@ubuntu:/home/leoy/linux/tools/perf# ./perf test -v 85 > 85: Check Arm SPE trace data recording and synthesized samples : > --- start --- > test child forked, pid 17083 > Recording trace with snapshot mode /tmp/__perf_test.perf.data.MI2iX > Looking at perf.data file for dumping samples: > Looking at perf.data file for reporting samples: > SPE snapshot testing: PASS > test child finished with 0 > ---- end ---- > Check Arm SPE trace data recording and synthesized samples: Ok > > BTW, you could see German has another patch set for enabling pid/tid > for Arm SPE tracing [1]. I confirmed that the pid/tid patch set and > current patch set have no conflit, and don't need worry the dependency > between these two patch sets (so you could apply two patch sets in any > ordering).
Thanks for the clarifications, applied, its out in my tmp.perf/core branch, that still needs some fixes for buiding on arm related to a recent patchset for 'perf test' from Ian Rogers, as soon as that is fixed it will be set in stone in perf/core.
- Arnaldo
| |