lkml.org 
[lkml]   [2021]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1] vmscan: make drop_slab_node static
From
On 11.11.21 07:24, Gang Li wrote:
> drop_slab_node is only used in drop_slab. So remove it's declaration from
> header file and add keyword static for it's definition.
>
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
> include/linux/mm.h | 1 -
> mm/vmscan.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index a7e4a9e7d807..08b36283a57a 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -3167,7 +3167,6 @@ int drop_caches_sysctl_handler(struct ctl_table *, int, void *, size_t *,
> #endif
>
> void drop_slab(void);
> -void drop_slab_node(int nid);
>
> #ifndef CONFIG_MMU
> #define randomize_va_space 0
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index fb9584641ac7..b02548a32a1d 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -951,7 +951,7 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid,
> return freed;
> }
>
> -void drop_slab_node(int nid)
> +static void drop_slab_node(int nid)
> {
> unsigned long freed;
> int shift = 0;
>

Reviewed-by: David Hildenbrand <david@redhat.com>

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2021-11-11 14:50    [W:0.047 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site