lkml.org 
[lkml]   [2021]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V1 1/2] mm/damon: Unified access_check function naming rules
Date
On Wed, 10 Nov 2021 20:13:13 +0800 Xin Hao <xhao@linux.alibaba.com> wrote:

> In damon/paddr.c file, two functions names start with underscore,
> static void __damon_pa_prepare_access_check(struct damon_ctx *ctx,
> struct damon_region *r)
> static void __damon_pa_prepare_access_check(struct damon_ctx *ctx,
> struct damon_region *r)
> In damon/vaddr.c file, there are also two functions with the same function,
> static void damon_va_prepare_access_check(struct damon_ctx *ctx,
> struct mm_struct *mm, struct damon_region *r)
> static void damon_va_check_access(struct damon_ctx *ctx,
> struct mm_struct *mm, struct damon_region *r)
>
> It makes sense to keep consistent, and it is not easy to be confused with
> the function that call them.
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]

\
 
 \ /
  Last update: 2021-11-10 14:01    [W:0.568 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site