Messages in this thread | | | Date | Wed, 10 Nov 2021 11:04:42 +0200 | From | Pekka Paalanen <> | Subject | Re: [PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem |
| |
On Wed, 3 Nov 2021 08:34:20 -0400 Neal Gompa <ngompa13@gmail.com> wrote:
> On Wed, Nov 3, 2021 at 8:32 AM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > > > Hi > > > > Am 03.11.21 um 12:05 schrieb Neal Gompa: > > > On Wed, Nov 3, 2021 at 6:48 AM Javier Martinez Canillas > > > <javierm@redhat.com> wrote: > > >> > > >> The "nomodeset" kernel cmdline parameter is handled by the vgacon driver > > >> but the exported vgacon_text_force() symbol is only used by DRM drivers. > > >> > > >> It makes much more sense for the parameter logic to be in the subsystem > > >> of the drivers that are making use of it. Let's move that to DRM. > > >> > > >> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> > > >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > > >> --- > > > > > > Please no, I'd much rather have a better, more meaningful option > > > instead of "nomodeset". If anything, I would like this option to > > > eventually do nothing and replace it with a better named option that's > > > namespaced by drm on the command-line. That was part of the feedback I > > > gave in the original patch set, and I still stand by that. > > > > This was nack'ed for now during irc chats with others. There was no > > clear semantics for the new parameter and nomodeset is good enough for > > now. I agree that nomodeset is badly named, though. > > > > Where are these chats happening? I'm mostly talking to Javier in the > #devel:fedoraproject.org Matrix room, so I don't know about anything > else...
OFTC IRC channel #dri-devel
Thanks, pq [unhandled content-type:application/pgp-signature] | |