Messages in this thread | | | From | Nick Desaulniers <> | Date | Wed, 10 Nov 2021 13:39:41 -0800 | Subject | Re: [PATCH] iwlwifi: pcie: fix constant-conversion warning |
| |
On Wed, Nov 10, 2021 at 1:38 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Thu, Nov 4, 2021 at 6:37 AM Arnd Bergmann <arnd@kernel.org> wrote: > > > > From: Arnd Bergmann <arnd@arndb.de> > > > > clang points out a potential issue with integer overflow when > > the iwl_dev_info_table[] array is empty: > > > > drivers/net/wireless/intel/iwlwifi/pcie/drv.c:1344:42: error: implicit conversion from 'unsigned long' to 'int' changes value from 18446744073709551615 to -1 [-Werror,-Wconstant-conversion] > > for (i = ARRAY_SIZE(iwl_dev_info_table) - 1; i >= 0; i--) { > > ~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > > > > This is still harmless, as the loop correctly terminates, but adding > > an (int) cast makes that clearer to the compiler. > > > > Fixes: 3f7320428fa4 ("iwlwifi: pcie: simplify iwl_pci_find_dev_info()") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Also, looks like 0day bot reported as well: https://lore.kernel.org/lkml/202111070825.gigxmmDq-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
-- Thanks, ~Nick Desaulniers
| |