lkml.org 
[lkml]   [2021]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] iommu/vt-d: Remove unused dma_to_mm_pfn function
On Sun, Nov 7, 2021 at 2:53 PM Maíra Canal <maira.canal@usp.br> wrote:
>
> Remove dma_to_buf_pfn function, which is not used in the codebase.
>
> This was pointed by clang with the following warning:
>
> drivers/iommu/intel/iommu.c:136:29: warning: unused function
> 'dma_to_mm_pfn' [-Wunused-function]
> static inline unsigned long dma_to_mm_pfn(unsigned long dma_pfn)
> ^

Thanks for the patch!
Fixes: dd4e831960e4f ("intel-iommu: Change dma_set_pte_addr() to
dma_set_pte_pfn()")
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

>
> Signed-off-by: Maíra Canal <maira.canal@usp.br>
> ---
> drivers/iommu/intel/iommu.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 0bde0c8b4126..35300b5b69f7 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -133,11 +133,6 @@ static inline unsigned long lvl_to_nr_pages(unsigned int lvl)
>
> /* VT-d pages must always be _smaller_ than MM pages. Otherwise things
> are never going to work. */
> -static inline unsigned long dma_to_mm_pfn(unsigned long dma_pfn)
> -{
> - return dma_pfn >> (PAGE_SHIFT - VTD_PAGE_SHIFT);
> -}
> -
> static inline unsigned long mm_to_dma_pfn(unsigned long mm_pfn)
> {
> return mm_pfn << (PAGE_SHIFT - VTD_PAGE_SHIFT);
> --
> 2.31.1
>


--
Thanks,
~Nick Desaulniers

\
 
 \ /
  Last update: 2021-11-10 21:21    [W:0.051 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site