Messages in this thread | | | Date | Wed, 10 Nov 2021 09:28:12 +0100 | Subject | Re: [PATCH 1/7] fs/exec: make __set_task_comm always set a nul terminated string | From | David Hildenbrand <> |
| |
On 08.11.21 09:38, Yafang Shao wrote: > Make sure the string set to task comm is always nul terminated. >
strlcpy: "the result is always a valid NUL-terminated string that fits in the buffer"
The only difference seems to be that strscpy_pad() pads the remainder with zeroes.
Is this description correct and I am missing something important?
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com> > Reviewed-by: Kees Cook <keescook@chromium.org> > Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> > Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com> > Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com> > Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com> > Cc: Michal Miroslaw <mirq-linux@rere.qmqm.pl> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Matthew Wilcox <willy@infradead.org> > Cc: David Hildenbrand <david@redhat.com> > Cc: Al Viro <viro@zeniv.linux.org.uk> > Cc: Kees Cook <keescook@chromium.org> > Cc: Petr Mladek <pmladek@suse.com> > --- > fs/exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/exec.c b/fs/exec.c > index a098c133d8d7..404156b5b314 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -1224,7 +1224,7 @@ void __set_task_comm(struct task_struct *tsk, const char *buf, bool exec) > { > task_lock(tsk); > trace_task_rename(tsk, buf); > - strlcpy(tsk->comm, buf, sizeof(tsk->comm)); > + strscpy_pad(tsk->comm, buf, sizeof(tsk->comm)); > task_unlock(tsk); > perf_event_comm(tsk, exec); > } >
-- Thanks,
David / dhildenb
| |