Messages in this thread | | | From | Nick Desaulniers <> | Date | Wed, 10 Nov 2021 12:01:09 -0800 | Subject | Re: [PATCH 1/2] x86/vdso: remove -nostdlib compiler flag |
| |
On Sun, Nov 7, 2021 at 8:27 AM Masahiro Yamada <masahiroy@kernel.org> wrote: > > The -nostdlib option requests the compiler to not use the standard > system startup files or libraries when linking. It is effective only > when $(CC) is used as a linker driver. > > Since > > 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") > > $(LD) is directly used, hence -nostdlib is unneeded. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Thanks for the patch! Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> --- > > arch/x86/entry/vdso/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile > index a2dddcc189f6..693f8b9031fb 100644 > --- a/arch/x86/entry/vdso/Makefile > +++ b/arch/x86/entry/vdso/Makefile > @@ -172,7 +172,7 @@ $(obj)/vdso32.so.dbg: $(obj)/vdso32/vdso32.lds $(vobjs32) FORCE > # The DSO images are built using a special linker script. > # > quiet_cmd_vdso = VDSO $@ > - cmd_vdso = $(LD) -nostdlib -o $@ \ > + cmd_vdso = $(LD) -o $@ \ > $(VDSO_LDFLAGS) $(VDSO_LDFLAGS_$(filter %.lds,$(^F))) \ > -T $(filter %.lds,$^) $(filter %.o,$^) && \ > sh $(srctree)/$(src)/checkundef.sh '$(NM)' '$@' > -- > 2.30.2 > > -- > You received this message because you are subscribed to the Google Groups "Clang Built Linux" group. > To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20211107162641.324688-1-masahiroy%40kernel.org.
-- Thanks, ~Nick Desaulniers
| |