Messages in this thread | | | Date | Mon, 1 Nov 2021 14:39:08 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH] staging: mm: Fix ERROR:do not initialise statics to 0 or NULL in memblock.c |
| |
On Mon, Nov 01, 2021 at 03:47:19PM +0530, Kushal Kothari wrote: > The default value of static variable is zero and bool is false so > not need to set it here. > This patch fixes this ERROR in memblock.c
Why does the subject line say "staging"? What tool reports this as an "ERROR"?
> Signed-off-by: Kushal Kothari <kushalkothari285@gmail.com> > --- > mm/memblock.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/memblock.c b/mm/memblock.c > index 5c3503c98b2f..57b9153b2278 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -16,7 +16,7 @@ > #include <linux/kmemleak.h> > #include <linux/seq_file.h> > #include <linux/memblock.h> > - > +#include<stdbool.h>
Why are you including stdbool here? Why do you not justify it in the changelog?
| |