lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] x86/kexec: fix memory leak of elf header buffer
Hi Baoquan,

On 10/29/21 at 03:24pm, Baoquan He wrote:
> The memory leak is reported by kmemleak detector, has been existing
> for very long time. It could casue much memory loss on large machine
> with huge memory hotplug which will trigger kdump kernel reloading
> many times, with kexec_file_load interface.
>
> And in patch 2, 3, clean up is done to remove unnecessary elf header
> buffer freeing and unneeded arch_kexec_kernel_image_load().
>
> Baoquan He (3):
> x86/kexec: fix memory leak of elf header buffer
> x86/kexec: remove incorrect elf header buffer freeing
> kexec_file: clean up arch_kexec_kernel_image_load
>
> arch/x86/kernel/machine_kexec_64.c | 23 +++++++++--------------
> include/linux/kexec.h | 1 -
> kernel/kexec_file.c | 9 ++-------
> 3 files changed, 11 insertions(+), 22 deletions(-)
>
> --
> 2.17.2
>

Acked-by: Dave Young <dyoung@redhat.com>

nitpick: the first two patches can be merged togeter, but I'm also fine if
they are in two patches.

Thanks
Dave

\
 
 \ /
  Last update: 2021-11-01 07:55    [W:0.193 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site