lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Need help in debugging "memory leak in em28xx_init_dev"
From
On 11/1/21 12:58, Dongliang Mu wrote:
> On Mon, Nov 1, 2021 at 5:43 PM Pavel Skripkin <paskripkin@gmail.com> wrote:
>>
>> On 11/1/21 12:41, Dongliang Mu wrote:
>> >> Hi, Dongliang,
>> >>
>> >> Did patch attached to my previous email pass syzbot's reproducer test?
>> >> Unfortunately, I am not able to test rn :(
>> >
>> > Yes, it works. The memory leak does not occur anymore.
>> >
>> > But I am crafting another patch based on yours as there is a small
>> > issue in the retval and I would like to make the error handling code
>> > uniform.
>> >
>>
>> Cool! Thank you for confirmation.
>
> Hi Pavel,
>
> Thanks for your advice. I have sent the patch and you are on the CC
> list. Can you please take a look at and review my patch?
>
> It should cover your patch. But I am not sure if I introduce any new
> issue in the patch.
>

The patch LGTM, but I can't drop R-b tag, since I am not an expert in
this driver. Anyway, there is 100% missing clean up, so, I believe, you
don't introduce new bugs



With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2021-11-01 13:19    [W:0.173 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site