lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/4] coresight: etm4x: Add lock for reading virtual context ID comparator
Hi Suzuki,

On Mon, Nov 01, 2021 at 09:49:06AM +0000, Suzuki Kuruppassery Poulose wrote:
> Hi Leo
>
> On 31/10/2021 14:42, Leo Yan wrote:
> > When read the virtual context ID comparator value via sysfs node, the
> > driver firstly reads out the index, then reads the comparator value
> > based on index. >
> > This patch adds the spinlock to protect the atomicity for up two steps.
>
> minor nit: This could be :
>
> "Updates to the values and the index are protected via the
> spinlock. Ensure we use the same lock to read the value
> safely"

Yeah, this is more simple and clear. Will use it.

> With that:
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Thanks for review.

Leo

\
 
 \ /
  Last update: 2021-11-01 12:03    [W:0.044 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site