Messages in this thread | | | Date | Mon, 1 Nov 2021 11:17:59 +0100 | Subject | Re: [PATCH 0/6] MODULE_DEVICE_TABLE() support for the ISHTP bus | From | Hans de Goede <> |
| |
Hi,
On 11/1/21 11:12, Thomas Weißschuh wrote: > On 2021-11-01 10:56+0100, Hans de Goede wrote: >> On 10/29/21 17:28, Thomas Weißschuh wrote: >>> Currently as soon as any ISHTP device appears all available ISHTP device >>> drivers are loaded automatically. >>> This series extends the MODULE_DEVICE_TABLE() functionality to properly handle >>> the ishtp bus and switches the drivers over to use it. >>> >>> Patch 1 adds the infrastructure to handle ishtp devices via MODULE_DEVICE_TABLE() >>> Patch 2 replaces some inlined constants with ones now defined by mod_devicetable.h >>> Patches 3-6 migrate all ishtp drivers to MODULE_DEVICE_TABLE() >>> >>> Note: This patchset is based on the pdx86/for-next tree because that contains >>> one of the drivers that is not yet in the other trees. >> >> Since most of the changes here are under drivers/hid and since the latter >> patches depend on 1/6, I believe it would be best to merge the entire series >> through the HID tree, here is my ack for this: >> >> Acked-by: Hans de Goede <hdegoede@redhat.com> > > Please note that patch 6 modifies a driver that is not yet available in the HID > and 5.15 trees but only in pdx86/for-next.
Right, but given where we are in the cycle this is going to be something to merge post 5.16-rc1 anyways which resolves the dependency issue.
I guess it might be good to send this our in a later pull-req as a fix series for a later 5.16-rc# though, to avoid the eclite and chrome-ec drivers from autoloading on all systems with an ISH, even though they usually will not be used there.
Regards,
Hans
| |