lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 074/125] reset: brcmstb-rescal: fix incorrect polarity of status bit
    Date
    From: Jim Quinlan <jim2101024@gmail.com>

    commit f33eb7f29c16ba78db3221ee02346fd832274cdd upstream.

    The readl_poll_timeout() should complete when the status bit
    is a 1, not 0.

    Fixes: 4cf176e52397 ("reset: Add Broadcom STB RESCAL reset controller")
    Signed-off-by: Jim Quinlan <jim2101024@gmail.com>
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Link: https://lore.kernel.org/r/20210914221122.62315-1-f.fainelli@gmail.com
    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/reset/reset-brcmstb-rescal.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/reset/reset-brcmstb-rescal.c
    +++ b/drivers/reset/reset-brcmstb-rescal.c
    @@ -38,7 +38,7 @@ static int brcm_rescal_reset_set(struct
    }

    ret = readl_poll_timeout(base + BRCM_RESCAL_STATUS, reg,
    - !(reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
    + (reg & BRCM_RESCAL_STATUS_BIT), 100, 1000);
    if (ret) {
    dev_err(data->dev, "time out on SATA/PCIe rescal\n");
    return ret;

    \
     
     \ /
      Last update: 2021-11-01 10:53    [W:4.215 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site