lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v7 01/11] fs/exec: make __set_task_comm always set a nul terminated string
    Date
    Make sure the string set to task comm is always nul terminated.

    Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
    Reviewed-by: Kees Cook <keescook@chromium.org>
    Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
    Cc: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
    Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>
    Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: Kees Cook <keescook@chromium.org>
    Cc: Petr Mladek <pmladek@suse.com>
    ---
    fs/exec.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/exec.c b/fs/exec.c
    index a098c133d8d7..404156b5b314 100644
    --- a/fs/exec.c
    +++ b/fs/exec.c
    @@ -1224,7 +1224,7 @@ void __set_task_comm(struct task_struct *tsk, const char *buf, bool exec)
    {
    task_lock(tsk);
    trace_task_rename(tsk, buf);
    - strlcpy(tsk->comm, buf, sizeof(tsk->comm));
    + strscpy_pad(tsk->comm, buf, sizeof(tsk->comm));
    task_unlock(tsk);
    perf_event_comm(tsk, exec);
    }
    --
    2.17.1
    \
     
     \ /
      Last update: 2021-11-01 07:05    [W:2.257 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site