lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 28/35] net: ethernet: microchip: lan743x: Fix driver crash when lan743x_pm_resume fails
    Date
    From: Yuiko Oshino <yuiko.oshino@microchip.com>

    commit d6423d2ec39cce2bfca418c81ef51792891576bc upstream.

    The driver needs to clean up and return when the initialization fails on resume.

    Fixes: 23f0703c125b ("lan743x: Add main source files for new lan743x driver")
    Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/microchip/lan743x_main.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/net/ethernet/microchip/lan743x_main.c
    +++ b/drivers/net/ethernet/microchip/lan743x_main.c
    @@ -3003,6 +3003,8 @@ static int lan743x_pm_resume(struct devi
    if (ret) {
    netif_err(adapter, probe, adapter->netdev,
    "lan743x_hardware_init returned %d\n", ret);
    + lan743x_pci_cleanup(adapter);
    + return ret;
    }

    /* open netdev when netdev is at running state while resume.

    \
     
     \ /
      Last update: 2021-11-01 10:26    [W:4.629 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site