Messages in this thread | | | Subject | Re: [PATCH] iommu/dma: fix incorrect error return on iommu deferred attach | From | John Garry <> | Date | Mon, 1 Nov 2021 09:21:20 +0000 |
| |
On 27/10/2021 18:47, Logan Gunthorpe wrote: > scsi_dma_map() was reporting a failure during boot on an AMD machine > with the IOMMU enabled. > > scsi_dma_map failed: request for 36 bytes! > > The issue was tracked down to a mistake in logic: should not return > an error if iommu_deferred_attach() returns zero. > > Reported-by: Marshall Midden<marshallmidden@gmail.com> > Fixes: dabb16f67215 ("iommu/dma: return error code from iommu_dma_map_sg()") > Link:https://lore.kernel.org/all/CAD2CkAWjS8=kKwEEN4cgVNjyFORUibzEiCUA-X+SMtbo0JoMmA@mail.gmail.com > Signed-off-by: Logan Gunthorpe<logang@deltatee.com> > Cc: Joerg Roedel<joro@8bytes.org> > Cc: Will Deacon<will@kernel.org>
Seems reasonable, FWIW: Reviewed-by: John Garry <john.garry@huawei.com>
| |