lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] iommu/dma: fix incorrect error return on iommu deferred attach
From
Date
On 27/10/2021 18:47, Logan Gunthorpe wrote:
> scsi_dma_map() was reporting a failure during boot on an AMD machine
> with the IOMMU enabled.
>
> scsi_dma_map failed: request for 36 bytes!
>
> The issue was tracked down to a mistake in logic: should not return
> an error if iommu_deferred_attach() returns zero.
>
> Reported-by: Marshall Midden<marshallmidden@gmail.com>
> Fixes: dabb16f67215 ("iommu/dma: return error code from iommu_dma_map_sg()")
> Link:https://lore.kernel.org/all/CAD2CkAWjS8=kKwEEN4cgVNjyFORUibzEiCUA-X+SMtbo0JoMmA@mail.gmail.com
> Signed-off-by: Logan Gunthorpe<logang@deltatee.com>
> Cc: Joerg Roedel<joro@8bytes.org>
> Cc: Will Deacon<will@kernel.org>

Seems reasonable, FWIW:
Reviewed-by: John Garry <john.garry@huawei.com>

\
 
 \ /
  Last update: 2021-11-01 10:25    [W:0.035 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site