lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] mmc: core: transplant ti,wl1251 quirks from to be retired omap_hsmmc
From
Date
Hi Jerome and Ulf,

> Am 28.10.2021 um 12:07 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
>
>
>
>> Am 28.10.2021 um 11:55 schrieb Jérôme Pouiller <jerome.pouiller@silabs.com>:
>>
>> On Thursday 28 October 2021 11:40:59 CEST H. Nikolaus Schaller wrote:
>>>> Am 28.10.2021 um 10:59 schrieb Jérôme Pouiller <jerome.pouiller@silabs.com>:
>>>> On Thursday 28 October 2021 09:08:50 CEST H. Nikolaus Schaller wrote:
>>>>
>>>>>> Let me have a closer look - and for sure, I am willing to help if needed.
>>>>
>>>> I confirm it does not have the expected behavior. !mmc_fixup_of_compatible_match()
>>>> should be mmc_fixup_of_compatible_match(), sorry.

I did take a deeper look and contrary to my first analyses your original patches
are correct. I did not completely understand how it was intended to be used
and how to match the compatible entry.

>>>
>>> Ok, I see.
>>>
>>> One more question: how can I specify "ti,wl1251" in some struct mmc_fixup table?
>>> Does it need another macro like MMC_FIXUP() or SDIO_FIXUP() to set the .name
>>> field?
>>
>> yes, I didn't provide it with my RFC.

Now I was able to make a version that works on the OpenPandora.

It does not yet use a macro to define the mmc_fixup table, but that can be
easily changed.

>
> I see.
>
> Starts to look like a good plan and we just have to execute it.
>
> Please notify if you have a new version to work with (it isn't urgent since the
> transplantation is only needed if omap_hsmmc is retired which depends on merge
> of the new driver).

I'll send an RFCv2 for the ti,wl1251 quirks now.

Best regards and thanks,
Nikolaus

\
 
 \ /
  Last update: 2021-11-01 10:13    [W:0.048 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site