Messages in this thread | | | Subject | Re: [PATCH net-next 0/2] MCTP sockaddr padding check/initialisation fixup | From | Jeremy Kerr <> | Date | Tue, 02 Nov 2021 09:57:34 +0800 |
| |
Hi Eugene,
> Padding/reserved fields necessitate appropriate checks in order to be > usable in the future.
We don't have a foreseeable need for extra fields here; so this is a bit hypothetical at the moment. However, I guess there may be something that comes up in future - was there something you have in mind?
The requirements for the padding bytes to be zero on sendmsg() will break the ABI for applications that are using the interface on 5.15; there's a small, contained set of those at the moment though, so I'm OK to handle the updates if this patch is accepted, but we'd need to make a call on that soon.
Setting the pad bytes to zero on recvmsg() is a good plan though, I'm happy for that change to go in regardless.
Cheers,
Jeremy
| |