Messages in this thread Patch in this message | | | From | Ye Bin <> | Subject | [PATCH -next v4 3/4] nbd: Fix incorrect error handle when first_minor is illegal in nbd_dev_add | Date | Tue, 2 Nov 2021 09:52:36 +0800 |
| |
If first_minor is illegal will goto out_free_idr label, this will miss cleanup disk.
Fixes: b1a811633f73 ("block: nbd: add sanity check for first_minor") Signed-off-by: Ye Bin <yebin10@huawei.com> --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index cc32b5bc0f49..88dc0c49631c 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1809,7 +1809,7 @@ static struct nbd_device *nbd_dev_add(int index, unsigned int refs) disk->first_minor = index << part_shift; if (disk->first_minor < index || disk->first_minor > MINORMASK) { err = -EINVAL; - goto out_free_idr; + goto out_err_disk; } disk->minors = 1 << part_shift; -- 2.31.1
| |