lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 15/21] iomap: Convert iomap_write_begin and iomap_write_end to folios
    Hi "Matthew,

    Thank you for the patch! Yet something to improve:

    [auto build test ERROR on hnaz-mm/master]
    [also build test ERROR on axboe-block/for-next linus/master next-20211101]
    [cannot apply to xfs-linux/for-next djwong-xfs/djwong-devel v5.15]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch]

    url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/iomap-xfs-folio-patches/20211102-052926
    base: https://github.com/hnaz/linux-mm master
    config: sparc64-randconfig-r035-20211101 (attached as .config)
    compiler: sparc64-linux-gcc (GCC) 11.2.0
    reproduce (this is a W=1 build):
    wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
    chmod +x ~/bin/make.cross
    # https://github.com/0day-ci/linux/commit/b3cbfa38e55d041252c57ee712d1bbb146a4aee8
    git remote add linux-review https://github.com/0day-ci/linux
    git fetch --no-tags linux-review Matthew-Wilcox-Oracle/iomap-xfs-folio-patches/20211102-052926
    git checkout b3cbfa38e55d041252c57ee712d1bbb146a4aee8
    # save the attached .config to linux build tree
    COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sparc64

    If you fix the issue, kindly add following tag as appropriate
    Reported-by: kernel test robot <lkp@intel.com>

    All errors (new ones prefixed by >>):

    fs/iomap/buffered-io.c: In function '__iomap_write_end':
    >> fs/iomap/buffered-io.c:657:9: error: implicit declaration of function 'flush_dcache_folio'; did you mean 'flush_dcache_page'? [-Werror=implicit-function-declaration]
    657 | flush_dcache_folio(folio);
    | ^~~~~~~~~~~~~~~~~~
    | flush_dcache_page
    cc1: some warnings being treated as errors


    vim +657 fs/iomap/buffered-io.c

    652
    653 static size_t __iomap_write_end(struct inode *inode, loff_t pos, size_t len,
    654 size_t copied, struct folio *folio)
    655 {
    656 struct iomap_page *iop = to_iomap_page(folio);
    > 657 flush_dcache_folio(folio);
    658
    659 /*
    660 * The blocks that were entirely written will now be uptodate, so we
    661 * don't have to worry about a readpage reading them and overwriting a
    662 * partial write. However, if we've encountered a short write and only
    663 * partially written into a block, it will not be marked uptodate, so a
    664 * readpage might come in and destroy our partial write.
    665 *
    666 * Do the simplest thing and just treat any short write to a
    667 * non-uptodate page as a zero-length write, and force the caller to
    668 * redo the whole thing.
    669 */
    670 if (unlikely(copied < len && !folio_test_uptodate(folio)))
    671 return 0;
    672 iomap_set_range_uptodate(folio, iop, offset_in_folio(folio, pos), len);
    673 filemap_dirty_folio(inode->i_mapping, folio);
    674 return copied;
    675 }
    676

    ---
    0-DAY CI Kernel Test Service, Intel Corporation
    https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
    [unhandled content-type:application/gzip]
    \
     
     \ /
      Last update: 2021-11-02 01:27    [W:3.436 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site