Messages in this thread | | | From | Ahmad Fatoum <> | Subject | Re: [PATCH] arm64: dts: imx8m: add syscon node for display_blk_ctrl module regs | Date | Mon, 1 Nov 2021 23:35:49 +0100 |
| |
Hello Tommaso,
On 01.11.21 23:28, Tommaso Merciai wrote: > Add system controller node for registers of module Display Block Control > (DISPLAY_BLK_CTRL, base address: 0x32e28000). > The DISPLAY_BLK_CTRL module contains general purpose registers (GPRs), > which control varied features of the associated peripherals. > Reference: IMX8MMRM Rev. 3, 11/2020, p 3897 > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index 2f632e8ca388..3e496b457e1a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -961,6 +961,11 @@ aips4: bus@32c00000 { > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > > + dispmix_gpr: display-gpr@32e28000 { > + compatible = "fsl, imx8mm-iomuxc-gpr", "syscon";
Please read vendor patches before submitting them. The space is out-of-place in the compatible and the compatible is wrong: This doesn't look like a i.MX8MM pin controller.
Cheers, Ahmad
> + reg = <0x32e28000 0x100>; > + }; > + > usbotg1: usb@32e40000 { > compatible = "fsl,imx8mm-usb", "fsl,imx7d-usb"; > reg = <0x32e40000 0x200>; >
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |