| Subject | Re: [PATCH 02/21] block: Add bio_add_folio() | From | Jens Axboe <> | Date | Mon, 1 Nov 2021 14:51:37 -0600 |
| |
On 11/1/21 2:39 PM, Matthew Wilcox (Oracle) wrote: > This is a thin wrapper around bio_add_page(). The main advantage here > is the documentation that stupidly large folios are not supported. > It's not currently possible to allocate stupidly large folios, but if > it ever becomes possible, this function will fail gracefully instead of > doing I/O to the wrong bytes.
Might be better with UINT_MAX instead of stupidly here, because then it immediately makes sense. Can you make a change to that effect?
With that:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
-- Jens Axboe
|