Messages in this thread | | | From | Sam Protsenko <> | Date | Fri, 8 Oct 2021 18:31:30 +0300 | Subject | Re: [PATCH v2 3/5] dt-bindings: clock: Add bindings definitions for Exynos850 CMU |
| |
On Fri, 8 Oct 2021 at 09:45, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > On 07/10/2021 21:41, Sam Protsenko wrote: > > Clock controller driver is designed to have separate instances for each > > particular CMU. So clock IDs in this bindings header also start from 1 > > for each CMU. > > > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > > Acked-by: Rob Herring <robh@kernel.org> > > --- > > Changes in v2: > > - Added all clock ids > > - Added CLK_ prefix for all clock constants > > - Added R-b tag by Krzysztof Kozlowski > > - Added Ack tag by Rob Herring > > > > include/dt-bindings/clock/exynos850.h | 141 ++++++++++++++++++++++++++ > > 1 file changed, 141 insertions(+) > > create mode 100644 include/dt-bindings/clock/exynos850.h > > > > diff --git a/include/dt-bindings/clock/exynos850.h b/include/dt-bindings/clock/exynos850.h > > new file mode 100644 > > index 000000000000..a44c5f91d3c7 > > --- /dev/null > > +++ b/include/dt-bindings/clock/exynos850.h > > @@ -0,0 +1,141 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > The bindings are preferred to be under GPL-2.0+BSD. I don't know about > such policy for the headers but it seems reasonable - allows re-usage in > other systems. Do you mind licensing it under: > GPL-2.0-only or BSD-2-Clause > ? >
Sure, will do in v3.
> Best regards, > Krzysztof > > > +/* > > + * Copyright (C) 2021 Linaro Ltd. > > + * Author: Sam Protsenko <semen.protsenko@linaro.org> > > + * > > + * Device Tree binding constants for Exynos850 clock controller. > > + */ > > + > > +#ifndef _DT_BINDINGS_CLOCK_EXYNOS_850_H > > +#define _DT_BINDINGS_CLOCK_EXYNOS_850_H > > + > > +/* CMU_TOP */
| |