lkml.org 
[lkml]   [2021]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 3/7] ABI: sysfs-class-hwmon: add a description for tempY_crit_alarm
Date
On 9/30/21 2:44 AM, Mauro Carvalho Chehab wrote:
> Such ABI symbol is currently not described. Document it.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> ---
>
> See [PATCH v2 0/7] at: https://lore.kernel.org/all/cover.1632994837.git.mchehab+huawei@kernel.org/
>
> Documentation/ABI/testing/sysfs-class-hwmon | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-hwmon b/Documentation/ABI/testing/sysfs-class-hwmon
> index ea5a129ae082..1f20687def44 100644
> --- a/Documentation/ABI/testing/sysfs-class-hwmon
> +++ b/Documentation/ABI/testing/sysfs-class-hwmon
> @@ -410,6 +410,20 @@ Description:
>
> RW
>
> +What: /sys/class/hwmon/hwmonX/tempY_crit_alarm
> +Description:
> + Critical high temperature alarm flag.
> +
> + - 0: OK
> + - 1: temperature has reached tempY_crit
> +
> + RW
> +
> + Contrary to regular alarm flags which clear themselves
> + automatically when read, this one sticks until cleared by
> + the user. This is done by writing 0 to the file. Writing
> + other values is unsupported.
> +

That is not really correct. It _may_ be current implementation for some drivers,
but such an implementation would not be correct. The proper implementation would
be to auto-clear the flag after it was read unless the condition persists.

> What: /sys/class/hwmon/hwmonX/tempY_crit_hyst
> Description:
> Temperature hysteresis value for critical limit.
>

This should be documented as part of the previous patch, together with
all other alarm attributes.

Guenter

\
 
 \ /
  Last update: 2021-10-08 16:53    [W:0.086 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site