lkml.org 
[lkml]   [2021]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v7 2/7] i2c: mediatek: Reset the handshake signal between i2c and dma
From
Date
On Sat, 2021-10-02 at 08:30 +0200, Wolfram Sang wrote:
> > +#define I2C_CLR_DEBUGCTR 0x0000
>
> Hmm, I don't think that a macro to clear a register helps
> readability...
>
> > + mtk_i2c_writew(i2c, I2C_CLR_DEBUGCTR,
> > OFFSET_DEBUGCTRL);
>
> ..
>
> + mtk_i2c_writew(i2c, 0, OFFSET_DEBUGCTRL);
>
> looks good to me. Anyhow, it is not a big issue. Let me know if you
> want
> to change it or keep it.
>
OK, I will use 0x00 instead of macro on V8 version,Thanks.

\
 
 \ /
  Last update: 2021-10-08 08:20    [W:0.080 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site