Messages in this thread | | | Subject | Re: [PATCH 5/5 v3] sh: fix READ/WRITE redefinition warnings | From | Randy Dunlap <> | Date | Fri, 8 Oct 2021 12:46:53 -0700 |
| |
On 10/8/21 11:39 AM, Rob Landley wrote: > On 10/4/21 7:19 PM, Randy Dunlap wrote: >> kernel.h defines READ and WRITE, so rename the SH math-emu macros >> to MREAD and MWRITE. > > This one doesn't apply for me. My file has: > > #define WRITE(d,a) ({if(put_user(d, (typeof (d)*)a)) return -EFAULT;}) > > But your patch tries to remove: > > -#define WRITE(d,a) ({if(put_user(d, (typeof (d) __user *)a)) return -EFAULT;}) > > Which is odd because git log says my tree is current as of today, but git log on > this file says it was last updated: > > commit 2e1661d2673667d886cd40ad9f414cb6db48d8da > Author: Eric W. Biederman <ebiederm@xmission.com> > Date: Thu May 23 11:04:24 2019 -0500 > > What did I miss?
Hi Rob,
I am making patches to linux-next, which contains this:
commit ca42bc4b7bda Author: Al Viro <viro@zeniv.linux.org.uk> Date: Thu Dec 31 23:23:01 2020 +0000
sh: fix trivial misannotations
which adds the __user annotations...
-- ~Randy
| |