Messages in this thread | | | Date | Thu, 7 Oct 2021 14:45:43 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] ASoC: dt-bindings: rt9120: Add initial bindings |
| |
On Thu, Oct 07, 2021 at 10:44:49AM +0800, ChiYuan Huang wrote: > ChiYuan Huang <u0084500@gmail.com> 於 2021年10月6日 週三 下午4:47寫道: > > ChiYuan Huang <u0084500@gmail.com> 於 2021年10月5日 週二 下午8:39寫道: > > > Mark Brown <broonie@kernel.org> 於 2021年10月5日 週二 下午8:29寫道:
> > > > > > I would expect this to be done through the regulator bindings, they > > > > > > would allow the driver to query the supply voltage.
> > > > Please don't take things off-list unless there is a really strong reason > > > > to do so. Sending things to the list ensures that everyone gets a > > > > chance to read and comment on things.
> > After contacting our HW RD, to support DVDD 1.8V not just SW config, > > also HW connections. > > To get only DVDD supply voltage is not enough to meet the HW design. > > The property seems indeed and need to be used by user's HW connection.
> > Can this property to be kept?
> After thinking, This property name may be improper. > I think this change depends on HW external circuit for lowv application. > Currently, I'm modifying the V3 change, this property name also affect > the property parsing code change. > May I directly change the name to 'richtek,dvdd-lowv-application' and > submit the patch v3?
I still don't understand why you wouldn't describe this through the regulator bindings, those exist to describe the physical supplies ont he board and their constraints. [unhandled content-type:application/pgp-signature] | |