Messages in this thread | | | Date | Wed, 6 Oct 2021 09:31:24 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] sched: task_struct: Fill unconditional hole induced by sched_entity |
| |
On Wed, Oct 06, 2021 at 11:27:03AM +0200, Peter Zijlstra wrote: > On Tue, Oct 05, 2021 at 09:48:51PM -0700, Kees Cook wrote: > > On Thu, Sep 23, 2021 at 07:54:50PM -0700, Kees Cook wrote: > > > With struct sched_entity before the other sched entities, its alignment > > > won't induce a struct hole. This saves 64 bytes in defconfig task_struct: > > > > Friendly ping. Can someone snag this for -tip please? > > Hurpmf... if only we had like perf driven pahole output :/
Normally I wouldn't even make suggestions in task_struct given the high variability due to CONFIG options, but this case was pretty universal.
> Picked it up, we'll see what if anything hurts.
Thanks! *fingers crossed*
-- Kees Cook
| |