Messages in this thread | | | From | Yang Shi <> | Date | Wed, 6 Oct 2021 19:49:51 -0700 | Subject | Re: [v3 PATCH 2/5] mm: filemap: check if THP has hwpoisoned subpage for PMD page fault |
| |
On Wed, Oct 6, 2021 at 1:18 PM Peter Xu <peterx@redhat.com> wrote: > > On Thu, Sep 30, 2021 at 02:53:08PM -0700, Yang Shi wrote: > > +#ifdef CONFIG_MEMORY_FAILURE > > + /* Compound pages. Stored in first tail page's flags */ > > + PG_has_hwpoisoned = PG_mappedtodisk, > > +#endif > > Sorry one more comment I missed: would PG_hwpoisoned_subpage better? It's just > that "has_hwpoison" can be directly read as "this page has been hwpoisoned", > which sounds too close to PG_hwpoisoned. No strong opinion either. Thanks,
TBH, I don't see too much difference IMHO. Someone may interpret it to "this" subpage is hwpoisoned rather than at least one subpage of THP is hwpoisoned.
> > -- > Peter Xu >
| |