Messages in this thread | | | Subject | Re: [PATCH] ASoC: qcom: soundwire: Enable soundwire bus clock for version 1.6 | From | Srinivasa Rao Mandadapu <> | Date | Tue, 5 Oct 2021 20:43:11 +0530 |
| |
On 10/5/2021 8:33 PM, Pierre-Louis Bossart wrote: > Thanks for Your time Bossart!!! > >>>> + ctrl->swrm_hctl_reg = devm_ioremap(&pdev->dev, >>>> swrm_hctl_reg, 0x4); >>> if (!ctrl->swrm_hctl_reg) >>> return -ENODEV; >>> >>> ? >> I think here error check is not required, as this change is required >> only for soundwire version 1.6 and above. > My comment had nothing to do with versions, it's just that ioremap can > fail and in general it's wise to test for errors...
Okay. My intention is if offset (swrm_hctl_reg) is zero, devm_ioremap may return error.
In that case we need to ignore error.
-- Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
| |