Messages in this thread | | | Date | Tue, 5 Oct 2021 15:39:15 +0200 | From | Heiko Carstens <> | Subject | Re: [PATCH v2] s390: Fix strrchr() implementation |
| |
On Tue, Oct 05, 2021 at 03:24:33PM +0200, Juergen Gross wrote: > On 05.10.21 15:14, Heiko Carstens wrote: > > On Tue, Oct 05, 2021 at 02:08:36PM +0200, Roberto Sassu wrote: > > > Fix two problems found in the strrchr() implementation for s390 > > > architectures: evaluate empty strings (return the string address instead of > > > NULL, if '\0' is passed as second argument); evaluate the first character > > > of non-empty strings (the current implementation stops at the second). > > > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > > Cc: stable@vger.kernel.org > > > Reported-by: Heiko Carstens <hca@linux.ibm.com> (incorrect behavior with empty strings) > > > Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> > > > --- > > > arch/s390/lib/string.c | 15 +++++++-------- > > > 1 file changed, 7 insertions(+), 8 deletions(-) > > > > Applied, thanks! > > > > Really? I just wanted to write a response: len is unsigned (size_t) > and compared to be >= 0, which sounds like always true.
Yeah.. I did some out-of-tree tests, but of course using int instead of unsigned int. However sparse complains also. So this wouldn't have hit upstream. Many thanks for pointing this out anyway!
| |