lkml.org 
[lkml]   [2021]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -rcu/kcsan 16/23] locking/atomics, kcsan: Add instrumentation for barriers
    On Tue, Oct 05, 2021 at 12:58:58PM +0200, Marco Elver wrote:
    > @@ -59,6 +60,7 @@ atomic_add(int i, atomic_t *v)
    > static __always_inline int
    > atomic_add_return(int i, atomic_t *v)
    > {
    > + kcsan_mb();
    > instrument_atomic_read_write(v, sizeof(*v));
    > return arch_atomic_add_return(i, v);
    > }

    This and others,.. is this actually correct? Should that not be
    something like:

    kscan_mb();
    instrument_atomic_read_write(...);
    ret = arch_atomic_add_return(i, v);
    kcsan_mb();
    return ret;

    ?

    \
     
     \ /
      Last update: 2021-10-05 14:04    [W:2.235 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site