Messages in this thread | | | Date | Wed, 6 Oct 2021 00:04:39 +0200 | Subject | Re: [PATCH 1/9] staging: r8188eu: remove an obsolete comment | From | Michael Straube <> |
| |
On 10/5/21 22:08, Martin Kaiser wrote: > The function that this comment describes is not present in the > r8188eu driver. The comment can be removed. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > --- > drivers/staging/r8188eu/hal/usb_halinit.c | 15 --------------- > 1 file changed, 15 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c > index 83813388de24..ab7b80144403 100644 > --- a/drivers/staging/r8188eu/hal/usb_halinit.c > +++ b/drivers/staging/r8188eu/hal/usb_halinit.c > @@ -624,21 +624,6 @@ static void _InitAntenna_Selection(struct adapter *Adapter) > DBG_88E("%s,Cur_ant:(%x)%s\n", __func__, haldata->CurAntenna, (haldata->CurAntenna == Antenna_A) ? "Antenna_A" : "Antenna_B"); > } > > -/*----------------------------------------------------------------------------- > - * Function: HwSuspendModeEnable92Cu() > - * > - * Overview: HW suspend mode switch. > - * > - * Input: NONE > - * > - * Output: NONE > - * > - * Return: NONE > - * > - * Revised History: > - * When Who Remark > - * 08/23/2010 MHC HW suspend mode switch test.. > - *---------------------------------------------------------------------------*/ > enum rt_rf_power_state RfOnOffDetect(struct adapter *adapt) > { > u8 val8; >
Hi Martin,
patch looks good, just one note. The function RfOnOffDetect() is not used and could be removed as well.
Regards, Michael
| |