lkml.org 
[lkml]   [2021]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 1/8] PCI/AER: Remove ID from aer_agent_string[]
    Date
    Currently, we do not print the "id" field in the AER error logs. Yet the
    aer_agent_string[] has the word "id" in it. The AER error log looks
    like:

    pcieport 0000:00:03.0: PCIe Bus Error: severity=Corrected, type=Data Link Layer, (Receiver ID)

    Without the "id" field in the error log, The aer_agent_string[]
    (eg: "Receiver ID") does not make sense. A user reading the
    aer_agent_string[] in the log, might inadvertently look for an "id"
    field and not finding it might lead to confusion.

    Remove the "ID" from the aer_agent_string[].

    The following are sample dummy errors inject via aer-inject.

    Before
    =======

    In 010caed4ccb6 ("PCI/AER: Decode Error Source Requester ID"),
    the "id" field was removed from the AER error logs, so currently AER
    logs look like:

    pcieport 0000:00:03.0: AER: Corrected error received: 0000:00:03:0
    pcieport 0000:00:03.0: PCIe Bus Error: severity=Corrected, type=Data Link Layer, (Receiver ID) <--- no id field
    pcieport 0000:00:03.0: device [1b36:000c] error status/mask=00000040/0000e000
    pcieport 0000:00:03.0: [ 6] BadTLP

    After
    ======

    pcieport 0000:00:03.0: AER: Corrected error received: 0000:00:03.0
    pcieport 0000:00:03.0: PCIe Bus Error: severity=Corrected, type=Data Link Layer, (Receiver)
    pcieport 0000:00:03.0: device [1b36:000c] error status/mask=00000040/0000e000
    pcieport 0000:00:03.0: [ 6] BadTLP

    Signed-off-by: Naveen Naidu <naveennaidu479@gmail.com>
    ---
    drivers/pci/pcie/aer.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
    index 9784fdcf3006..241ff361b43c 100644
    --- a/drivers/pci/pcie/aer.c
    +++ b/drivers/pci/pcie/aer.c
    @@ -516,10 +516,10 @@ static const char *aer_uncorrectable_error_string[] = {
    };

    static const char *aer_agent_string[] = {
    - "Receiver ID",
    - "Requester ID",
    - "Completer ID",
    - "Transmitter ID"
    + "Receiver",
    + "Requester",
    + "Completer",
    + "Transmitter"
    };

    #define aer_stats_dev_attr(name, stats_array, strings_array, \
    @@ -703,7 +703,7 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info)
    const char *level;

    if (!info->status) {
    - pci_err(dev, "PCIe Bus Error: severity=%s, type=Inaccessible, (Unregistered Agent ID)\n",
    + pci_err(dev, "PCIe Bus Error: severity=%s, type=Inaccessible, (Unregistered Agent)\n",
    aer_error_severity_string[info->severity]);
    goto out;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-10-05 19:20    [W:2.513 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site