lkml.org 
[lkml]   [2021]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 111/172] RDMA/hfi1: Fix kernel pointer leak
    Date
    From: Guo Zhi <qtxuning1999@sjtu.edu.cn>

    [ Upstream commit 7d5cfafe8b4006a75b55c2f1fdfdb363f9a5cc98 ]

    Pointers should be printed with %p or %px rather than cast to 'unsigned
    long long' and printed with %llx. Change %llx to %p to print the secured
    pointer.

    Fixes: 042a00f93aad ("IB/{ipoib,hfi1}: Add a timeout handler for rdma_netdev")
    Link: https://lore.kernel.org/r/20210922134857.619602-1-qtxuning1999@sjtu.edu.cn
    Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
    Acked-by: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/hfi1/ipoib_tx.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/infiniband/hw/hfi1/ipoib_tx.c b/drivers/infiniband/hw/hfi1/ipoib_tx.c
    index 993f9838b6c8..e1fdeadda437 100644
    --- a/drivers/infiniband/hw/hfi1/ipoib_tx.c
    +++ b/drivers/infiniband/hw/hfi1/ipoib_tx.c
    @@ -873,14 +873,14 @@ void hfi1_ipoib_tx_timeout(struct net_device *dev, unsigned int q)
    struct hfi1_ipoib_txq *txq = &priv->txqs[q];
    u64 completed = atomic64_read(&txq->complete_txreqs);

    - dd_dev_info(priv->dd, "timeout txq %llx q %u stopped %u stops %d no_desc %d ring_full %d\n",
    - (unsigned long long)txq, q,
    + dd_dev_info(priv->dd, "timeout txq %p q %u stopped %u stops %d no_desc %d ring_full %d\n",
    + txq, q,
    __netif_subqueue_stopped(dev, txq->q_idx),
    atomic_read(&txq->stops),
    atomic_read(&txq->no_desc),
    atomic_read(&txq->ring_full));
    - dd_dev_info(priv->dd, "sde %llx engine %u\n",
    - (unsigned long long)txq->sde,
    + dd_dev_info(priv->dd, "sde %p engine %u\n",
    + txq->sde,
    txq->sde ? txq->sde->this_idx : 0);
    dd_dev_info(priv->dd, "flow %x\n", txq->flow.as_int);
    dd_dev_info(priv->dd, "sent %llu completed %llu used %llu\n",
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-10-04 15:38    [W:6.436 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site