lkml.org 
[lkml]   [2021]   [Oct]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 2/3] staging: vt6655: fix camelcase in ldBmThreshold
    Date
    Replace camel case variable ldBmThreshold with snake case
    variable dbm_threshold. ldBmThreshold is in hungarian notation, where
    "l" is for long and "dbm" is for decibel-milliwatt (signal strenght).
    This variable contain's signal strenght threshold in dbm.

    References:
    - https://en.wikipedia.org/wiki/Hungarian_notation
    - https://www.rapidtables.com/electric/dBm.html

    Signed-off-by: Tommaso Merciai <tomm.merciai@gmail.com>
    ---
    Changes since v5:
    - Fix variable name dbm_threshold instead of ld_bm_threshold
    - Add more details in commit message

    Changes since v4:
    - Make the commit body message more clearer

    Changes since v3:
    - Fix patch changelog

    Changes since v2:
    - Add patch changelog

    Changes since v1:
    - Make the commit message more clearer

    drivers/staging/vt6655/baseband.c | 48 ++++++++++++++--------------
    drivers/staging/vt6655/device.h | 4 +--
    drivers/staging/vt6655/device_main.c | 2 +-
    3 files changed, 27 insertions(+), 27 deletions(-)

    diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
    index 491cf4d8bc6c..7ae6ae984e2d 100644
    --- a/drivers/staging/vt6655/baseband.c
    +++ b/drivers/staging/vt6655/baseband.c
    @@ -2021,10 +2021,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
    priv->abyBBVGA[1] = 0x0A;
    priv->abyBBVGA[2] = 0x0;
    priv->abyBBVGA[3] = 0x0;
    - priv->ldBmThreshold[0] = -70;
    - priv->ldBmThreshold[1] = -50;
    - priv->ldBmThreshold[2] = 0;
    - priv->ldBmThreshold[3] = 0;
    + priv->dbm_threshold[0] = -70;
    + priv->dbm_threshold[1] = -50;
    + priv->dbm_threshold[2] = 0;
    + priv->dbm_threshold[3] = 0;
    } else if ((by_rf_type == RF_AIROHA) || (by_rf_type == RF_AL2230S)) {
    for (ii = 0; ii < CB_VT3253B0_INIT_FOR_AIROHA2230; ii++)
    result &= bb_write_embedded(priv,
    @@ -2039,10 +2039,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
    priv->abyBBVGA[1] = 0x10;
    priv->abyBBVGA[2] = 0x0;
    priv->abyBBVGA[3] = 0x0;
    - priv->ldBmThreshold[0] = -70;
    - priv->ldBmThreshold[1] = -48;
    - priv->ldBmThreshold[2] = 0;
    - priv->ldBmThreshold[3] = 0;
    + priv->dbm_threshold[0] = -70;
    + priv->dbm_threshold[1] = -48;
    + priv->dbm_threshold[2] = 0;
    + priv->dbm_threshold[3] = 0;
    } else if (by_rf_type == RF_UW2451) {
    for (ii = 0; ii < CB_VT3253B0_INIT_FOR_UW2451; ii++)
    result &= bb_write_embedded(priv,
    @@ -2061,10 +2061,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
    priv->abyBBVGA[1] = 0x0A;
    priv->abyBBVGA[2] = 0x0;
    priv->abyBBVGA[3] = 0x0;
    - priv->ldBmThreshold[0] = -60;
    - priv->ldBmThreshold[1] = -50;
    - priv->ldBmThreshold[2] = 0;
    - priv->ldBmThreshold[3] = 0;
    + priv->dbm_threshold[0] = -60;
    + priv->dbm_threshold[1] = -50;
    + priv->dbm_threshold[2] = 0;
    + priv->dbm_threshold[3] = 0;
    } else if (by_rf_type == RF_UW2452) {
    for (ii = 0; ii < CB_VT3253B0_INIT_FOR_UW2451; ii++)
    result &= bb_write_embedded(priv,
    @@ -2107,10 +2107,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
    priv->abyBBVGA[1] = 0x0A;
    priv->abyBBVGA[2] = 0x0;
    priv->abyBBVGA[3] = 0x0;
    - priv->ldBmThreshold[0] = -60;
    - priv->ldBmThreshold[1] = -50;
    - priv->ldBmThreshold[2] = 0;
    - priv->ldBmThreshold[3] = 0;
    + priv->dbm_threshold[0] = -60;
    + priv->dbm_threshold[1] = -50;
    + priv->dbm_threshold[2] = 0;
    + priv->dbm_threshold[3] = 0;
    /* }} RobertYu */

    } else if (by_rf_type == RF_VT3226) {
    @@ -2127,10 +2127,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
    priv->abyBBVGA[1] = 0x10;
    priv->abyBBVGA[2] = 0x0;
    priv->abyBBVGA[3] = 0x0;
    - priv->ldBmThreshold[0] = -70;
    - priv->ldBmThreshold[1] = -48;
    - priv->ldBmThreshold[2] = 0;
    - priv->ldBmThreshold[3] = 0;
    + priv->dbm_threshold[0] = -70;
    + priv->dbm_threshold[1] = -48;
    + priv->dbm_threshold[2] = 0;
    + priv->dbm_threshold[3] = 0;
    /* Fix VT3226 DFC system timing issue */
    MACvSetRFLE_LatchBase(iobase);
    /* {{ RobertYu: 20050104 */
    @@ -2161,10 +2161,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
    priv->abyBBVGA[1] = 0x10;
    priv->abyBBVGA[2] = 0x0;
    priv->abyBBVGA[3] = 0x0;
    - priv->ldBmThreshold[0] = -70;
    - priv->ldBmThreshold[1] = -48;
    - priv->ldBmThreshold[2] = 0;
    - priv->ldBmThreshold[3] = 0;
    + priv->dbm_threshold[0] = -70;
    + priv->dbm_threshold[1] = -48;
    + priv->dbm_threshold[2] = 0;
    + priv->dbm_threshold[3] = 0;
    /* }} RobertYu */
    } else {
    /* No VGA Table now */
    diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
    index 49e3d09480f2..e74372263e14 100644
    --- a/drivers/staging/vt6655/device.h
    +++ b/drivers/staging/vt6655/device.h
    @@ -215,7 +215,7 @@ struct vnt_private {

    bool bEncryptionEnable;
    bool bLongHeader;
    - bool short_slot_time;
    + bool bShortSlotTime;
    bool bProtectMode;
    bool bNonERPPresent;
    bool bBarkerPreambleMd;
    @@ -253,7 +253,7 @@ struct vnt_private {
    unsigned char byBBVGANew;
    unsigned char byBBVGACurrent;
    unsigned char abyBBVGA[BB_VGA_LEVEL];
    - long ldBmThreshold[BB_VGA_LEVEL];
    + long dbm_threshold[BB_VGA_LEVEL];

    unsigned char byBBPreEDRSSI;
    unsigned char byBBPreEDIndex;
    diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
    index 52c2a6651bc9..ff6c59e198a4 100644
    --- a/drivers/staging/vt6655/device_main.c
    +++ b/drivers/staging/vt6655/device_main.c
    @@ -986,7 +986,7 @@ static void vnt_check_bb_vga(struct vnt_private *priv)
    RFvRSSITodBm(priv, (u8)priv->uCurrRSSI, &dbm);

    for (i = 0; i < BB_VGA_LEVEL; i++) {
    - if (dbm < priv->ldBmThreshold[i]) {
    + if (dbm < priv->dbm_threshold[i]) {
    priv->byBBVGANew = priv->abyBBVGA[i];
    break;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-10-05 00:33    [W:3.102 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site