Messages in this thread |  | | From | Sergio Paracuellos <> | Date | Sun, 31 Oct 2021 14:42:31 +0100 | Subject | Re: [PATCH v2] pinctrl: ralink: include 'ralink_regs.h' in 'pinctrl-mt7620.c' |
| |
Hi Andy,
On Sun, Oct 31, 2021 at 2:08 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sun, Oct 31, 2021 at 8:41 AM Sergio Paracuellos > <sergio.paracuellos@gmail.com> wrote: > > > > mt7620.h, included by pinctrl-mt7620.c, mentions MT762X_SOC_MT7628AN > > declared in ralink_regs.h. > > > > Fixes: 745ec436de72 ("pinctrl: ralink: move MT7620 SoC pinmux config into a new 'pinctrl-mt7620.c' file") > > Cc: stable@vger.kernel.org > > Cc: linus.walleij@linaro.org > > > > Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com> > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > Tag blocks mustn't have blank lines.
Ok, thanks for letting me know.
> > ... > > > +#include <asm/mach-ralink/ralink_regs.h> > > #include <asm/mach-ralink/mt7620.h> > > #include <linux/module.h> > > #include <linux/platform_device.h> > > Actually the rule of thumb is to start from more generic definitions / > inclusions to more particular. Thus, asm/* usually goes after linux/*. > Any Specific reason why here is not the case?
I just respect the order that was already in the files, I guess when I moved all of this from arch/mips into drivers/pinctrl. All files inside follows the same order.
Best regards, Sergio Paracuellos > > -- > With Best Regards, > Andy Shevchenko
|  |