Messages in this thread |  | | From | Andy Shevchenko <> | Date | Sun, 31 Oct 2021 14:52:11 +0200 | Subject | Re: [PATCH 13/13] extcon: intel-cht-wc: Add support for devices with an USB-micro-B connector |
| |
On Sat, Oct 30, 2021 at 9:29 PM Hans de Goede <hdegoede@redhat.com> wrote: > > So far the extcon-intel-cht-wc code has only been tested on devices with > a Type-C connector with USB-PD, USB3 (superspeed) and DP-altmode support > through a FUSB302 Type-C controller. > > Some devices with the intel-cht-wc PMIC however come with an USB-micro-B > connector, or an USB-2 only Type-C connector without USB-PD. > > These device are identified by "intel,cht-wc-setup" = "bq25890,bq27520", > since there is no Type-C controller on these devices the extcon code must > control the Vbus 5V boost converter and the USB role switch depending on > the detected cable-type.
...
> + if (ext->vbus_boost && ext->vbus_boost_enabled != enable) { > + if (enable) > + ret = regulator_enable(ext->vbus_boost); > + else > + ret = regulator_disable(ext->vbus_boost);
> + if (ret == 0) > + ext->vbus_boost_enabled = enable; > + else > + dev_err(ext->dev, "Error updating Vbus boost regulator: %d\n", ret);
if (ret) dev_err() else ...
?
> + }
...
> + /* > + * Classic micro USB-B setup, this requires controling
controlling
> + * the role-sw and vbus based on the id-pin. > + */
-- With Best Regards, Andy Shevchenko
|  |