Messages in this thread Patch in this message |  | | Date | Sun, 31 Oct 2021 10:16:23 -0000 | From | "tip-bot2 for Vincent Guittot" <> | Subject | [tip: sched/core] sched/fair: Cleanup newidle_balance |
| |
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 8ea9183db4ad8afbcb7089a77c23eaf965b0cacd Gitweb: https://git.kernel.org/tip/8ea9183db4ad8afbcb7089a77c23eaf965b0cacd Author: Vincent Guittot <vincent.guittot@linaro.org> AuthorDate: Tue, 19 Oct 2021 14:35:37 +02:00 Committer: Peter Zijlstra <peterz@infradead.org> CommitterDate: Sun, 31 Oct 2021 11:11:38 +01:00
sched/fair: Cleanup newidle_balance
update_next_balance() uses sd->last_balance which is not modified by load_balance() so we can merge the 2 calls in one place.
No functional change
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Reviewed-by: Dietmar Eggemann <dietmar.eggemann@arm.com> Acked-by: Mel Gorman <mgorman@suse.de> Link: https://lore.kernel.org/r/20211019123537.17146-6-vincent.guittot@linaro.org --- kernel/sched/fair.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 57eae0e..13950be 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10916,10 +10916,10 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf) int continue_balancing = 1; u64 domain_cost; - if (this_rq->avg_idle < curr_cost + sd->max_newidle_lb_cost) { - update_next_balance(sd, &next_balance); + update_next_balance(sd, &next_balance); + + if (this_rq->avg_idle < curr_cost + sd->max_newidle_lb_cost) break; - } if (sd->flags & SD_BALANCE_NEWIDLE) { @@ -10935,8 +10935,6 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf) t0 = t1; } - update_next_balance(sd, &next_balance); - /* * Stop searching for tasks to pull if there are * now runnable tasks on this rq.
|  |