Messages in this thread |  | | From | Dan Williams <> | Date | Sun, 31 Oct 2021 10:47:22 -0700 | Subject | Re: [PATCH 03/13] nvdimm/btt: do not call del_gendisk() if not needed |
| |
On Fri, Oct 15, 2021 at 4:53 PM Luis Chamberlain <mcgrof@kernel.org> wrote: > > We know we don't need del_gendisk() if we haven't added > the disk, so just skip it. This should fix a bug on older > kernels, as del_gendisk() became able to deal with > disks not added only recently, after the patch titled > "block: add flag for add_disk() completion notation".
Perhaps put this in:
commit $abbrev_commit ("block: add flag for add_disk() completion notation")
...format, but I can't seem to find that commit?
If you're touching the changelog how about one that clarifies the impact and drops "we"?
"del_gendisk() is not required if the disk has not been added. On kernels prior to commit $abbrev_commit ("block: add flag for add_disk() completion notation") it is mandatory to not call del_gendisk() if the underlying device has not been through device_add()."
Fixes: 41cd8b70c37a ("libnvdimm, btt: add support for blk integrity")
With that you can add:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
|  |