lkml.org 
[lkml]   [2021]   [Oct]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 09/13] power: supply: bq25890: Add bq25890_set_otg_cfg() helper
    On Sat, Oct 30, 2021 at 9:28 PM Hans de Goede <hdegoede@redhat.com> wrote:
    >
    > Add a bq25890_set_otg_cfg() helper function, this is a preparation
    > patch for adding regulator support.

    ...

    > switch (bq->usb_event) {
    > case USB_EVENT_ID:
    > /* Enable boost mode */
    > - ret = bq25890_field_write(bq, F_OTG_CFG, 1);
    > - if (ret < 0)
    > - goto error;
    > + bq25890_set_otg_cfg(bq, 1);
    > break;
    >
    > case USB_EVENT_NONE:
    > /* Disable boost mode */
    > - ret = bq25890_field_write(bq, F_OTG_CFG, 0);
    > - if (ret < 0)
    > - goto error;
    > -
    > - power_supply_changed(bq->charger);
    > + ret = bq25890_set_otg_cfg(bq, 0);
    > + if (ret == 0)
    > + power_supply_changed(bq->charger);
    > break;
    > }

    While at it,

    default:
    break;

    ?

    --
    With Best Regards,
    Andy Shevchenko

    \
     
     \ /
      Last update: 2021-10-31 00:11    [W:6.365 / U:0.352 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site