Messages in this thread | | | From | Andy Shevchenko <> | Date | Sun, 3 Oct 2021 09:39:44 +0300 | Subject | Re: [PATCH 0/3] Update ASUS WMI supported boards. |
| |
On Sun, Oct 3, 2021 at 12:10 AM Denis Pauk <pauk.denis@gmail.com> wrote: > > Add support to nct6775: > * PRIME B360-PLUS > * PRIME X570-PRO > * ROG CROSSHAIR VIII FORMULA > * ROG STRIX B550-I GAMING > * ROG STRIX X570-F GAMING > * ROG STRIX Z390-E GAMING > * TUF GAMING B550-PRO > * TUF GAMING Z490-PLUS > * TUF GAMING Z490-PLUS (WI-FI) > > Add sensors driver for ASUS motherboards to read sensors from the embedded > controller. Based on https://github.com/zeule/asus-wmi-ec-sensors. > > Could you please review?
I will look at the last patch later on.
> @Andy Shevchenko, @Guenter Roeck should I split last patch in some way? > Should I add to MAINTAINERS: > -- > ASUS WMI HARDWARE MONITOR DRIVER > M: Eugene Shalygin <eugene.shalygin@gmail.com> > M: Denis Pauk <pauk.denis@gmail.com> > L: linux-hwmon@vger.kernel.org > S: Maintained > F: drivers/hwmon/asus_wmi_sensors.c
I don't see right now if the last patch needs a split, but MAINTAINERS update is better to have.
...
> Signed-off-by: Denis Pauk <pauk.denis@gmail.com>
This makes a little sense in a cover letter (have you used --cover-letter parameter?).
> Co-developed-by: Eugene Shalygin <eugene.shalygin@gmail.com> > Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
This in a similar way, except the outcome is an appearing above mentioned name in the Cc.
> Tested-by: matt-testalltheway <sefoci9222@rerunway.com> > Tested-by: Kamil Dudka <kdudka@redhat.com> > Tested-by: Robert Swiecki <robert@swiecki.net> > Tested-by: Kamil Pietrzak <kpietrzak@disroot.org> > Tested-by: Igor <igor@svelig.com> > Tested-by: Tor Vic <torvic9@mailbox.org> > Tested-by: Poezevara <nephartyz@gmail.com>
This is fine (and will be reflected in Cc)
> Cc: Andy Shevchenko <andriy.shevchenko@intel.com> > Cc: Guenter Roeck <linux@roeck-us.net>
This I already talked about.
-- With Best Regards, Andy Shevchenko
| |